Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSOS-2406: remove unused ssm parameters #4214

Merged
merged 5 commits into from
Dec 1, 2023

Conversation

drobinson-moj
Copy link
Contributor

Remove SSM params that have been migrated to Secrets

@drobinson-moj drobinson-moj requested review from a team as code owners December 1, 2023 13:13
@github-actions github-actions bot added the environments-repository Used to exclude PRs from this repo in our Slack PR update label Dec 1, 2023
@drobinson-moj drobinson-moj had a problem deploying to hmpps-domain-services-development December 1, 2023 13:15 — with GitHub Actions Failure
@drobinson-moj drobinson-moj had a problem deploying to hmpps-domain-services-test December 1, 2023 13:15 — with GitHub Actions Failure
@drobinson-moj drobinson-moj had a problem deploying to nomis-combined-reporting-test December 1, 2023 13:15 — with GitHub Actions Failure
Copy link
Contributor

github-actions bot commented Dec 1, 2023

TFSEC Scan Success

Show Output
*****************************

TFSEC will check the following folders:
terraform/environments/planetfm

*****************************

Running TFSEC in terraform/environments/planetfm
Excluding the following checks: AWS095

======================================================
tfsec is joining the Trivy family

tfsec will continue to remain available 
for the time being, although our engineering 
attention will be directed at Trivy going forward.

You can read more here: 
https://github.com/aquasecurity/tfsec/discussions/1994
======================================================
  timings
  ──────────────────────────────────────────
  disk i/o             1.669791ms
  parsing              214.993407ms
  adaptation           115.275µs
  checks               3.478589ms
  total                220.257062ms

  counts
  ──────────────────────────────────────────
  modules downloaded   0
  modules processed    5
  blocks processed     271
  files read           71

  results
  ──────────────────────────────────────────
  passed               1
  ignored              0
  critical             0
  high                 0
  medium               0
  low                  0


No problems detected!

tfsec_exitcode=0

Checkov Scan Success

Show Output
*****************************

Checkov will check the following folders:
terraform/environments/planetfm

*****************************

Running Checkov in terraform/environments/planetfm
terraform scan results:

Passed checks: 94, Failed checks: 0, Skipped checks: 19


checkov_exitcode=0

CTFLint Scan Success

Show Output
*****************************

Setting default tflint config...
Running tflint --init...
Installing `terraform` plugin...
Installed `terraform` (source: github.com/terraform-linters/tflint-ruleset-terraform, version: 0.2.1)
tflint will check the following folders:
terraform/environments/planetfm

*****************************

Running tflint in terraform/environments/planetfm
Excluding the following checks: terraform_unused_declarations
tflint_exitcode=0

@drobinson-moj drobinson-moj merged commit 380a822 into main Dec 1, 2023
52 of 56 checks passed
@drobinson-moj drobinson-moj deleted the DSOS-2406/remove-ssm-parameters branch December 1, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
environments-repository Used to exclude PRs from this repo in our Slack PR update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants